Revert "[codegen] annotate member-access expressions with class/interface types"#666
Merged
Revert "[codegen] annotate member-access expressions with class/interface types"#666
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
#662 merged with all PR checks green on arm64 (local + macOS CI). After merge to main, CI on x86-64 Linux + macOS segfaults at Stage 0 → Stage 1 self-hosting:
```
Command failed: /tmp/chad-stage0 build -v src/chad-native.ts -o /tmp/chad-stage1 --target-cpu=x86-64
Segmentation fault (core dumped)
```
The member_access annotation generates IR that works on arm64 but segfaults the stage-0 compiler on x86-64. Likely an undefined-behavior case that `-O2` + x86-64 target exploits differently than arm64.
After
Main passes CI again. Gate-loosening step 2 (`member_access`) reverted; will reland after x86-64 repro.
Description
PR #662 slipped past its own CI because the PR-level matrix runs macOS+arm64 only (per my observation — `build-macos pass`, `build-linux-glibc pass` on the PR, but then `build-linux-glibc fail` after merge on main CI). Need to either add x86-64 Linux to PR CI or test locally with `--target-cpu=x86-64` before merge.
Refs #658.