[architecture] extract class field loading from member.ts#754
Merged
Conversation
cs01
force-pushed
the
decompose/extract-class-field-loading
branch
from
fddb604 to
33f63b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
member.tsis 3588 lines with class field loading logic (loadFieldValue, loadPrimitiveFieldValue, loadCollectionFieldValue, loadFallbackFieldValue, storeInterfaceMetadata, resolveConcreteClassByFields, findClassStructurallyMatchingInterface) embedded as class methods.After
No user-facing change. Internal refactor only.
member.tsreduced to 3311 lines (-277). Extracted 7 functions intoclass-field-loading.ts(331 lines) as free functions takingctxparameter. Class methods become thin delegators.Description
First extraction PR for #727 (decompose god files). Pure mechanical move — no behavior changes. Follows existing pattern from process-access.ts, property-handlers.ts, chained-access.ts, struct-access.ts.
Renamed
findClassStructurallyMatchingInterfacetofindStructuralClassForFieldto avoid name collision with same-named function in class-dispatch.ts (ChadScript flat module merging).