Skip to content

replace status effect with function#69

Merged
cs01 merged 1 commit intomasterfrom
cs01/set-status-effect
Jul 25, 2021
Merged

replace status effect with function#69
cs01 merged 1 commit intomasterfrom
cs01/set-status-effect

Conversation

@cs01
Copy link
Copy Markdown
Owner

@cs01 cs01 commented Jul 24, 2021

Summary of changes

useEffect for status changes was unnecessary. Replaced with a function that updates the state of status, then calls the status change handler.

Test plan

Tested by running

# cd termpair/frontend_src
yarn build
# cd ../..
nox -s serve
# in new terminal
nox -s share

then interact with browser to induce various states.

@cs01 cs01 changed the title replace status useEffect function replace status effect with function Jul 24, 2021
@cs01 cs01 merged commit 0e10bbc into master Jul 25, 2021
@cs01 cs01 deleted the cs01/set-status-effect branch July 25, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant