Skip to content

refactor frontend, remove effect, clean up logic#75

Merged
cs01 merged 3 commits intomasterfrom
cs01/refactor-frontend
Aug 8, 2021
Merged

refactor frontend, remove effect, clean up logic#75
cs01 merged 3 commits intomasterfrom
cs01/refactor-frontend

Conversation

@cs01
Copy link
Copy Markdown
Owner

@cs01 cs01 commented Aug 8, 2021

Summary of changes

  • Break app into smaller pieces/files
  • Clean up logic in react app by replacing calls to useEffect with regular functions. Instead of reacting to changes in variables, explicitly make calls to create the websocket connection when ready. This removes a lot of the "magic" from the way the code was behaving.
  • Upgrade npm packages with yarn upgrade

Test plan

Tested by running

make build_frontend
nox -s serve
nox -s broadcast

@cs01 cs01 merged commit 4f64a47 into master Aug 8, 2021
@cs01 cs01 deleted the cs01/refactor-frontend branch August 8, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant