Conversation
gobears01
left a comment
gobears01
left a comment
There was a problem hiding this comment.
I added Datatables dt.rows().nodes().each((node) to iterate through different pages of the assignment table to apply bulk changes if table size > 1 page. If <1, keep your existing queryforAll DOM action. Changes shown in gemfiles are related to Anthony's gem-dashboards branch where this branch was rebased onto. I can add the cucumber tests for the two actions after my PR is merged in. Otherwise, LGTM
| gem 'lograge' | ||
|
|
||
| # Environment variable management | ||
| gem 'dotenv-rails', require: 'dotenv/load' |
There was a problem hiding this comment.
dotenv-rails is already declared at line 36 with groups: [:development, :test]. This second declaration has no group, which overrides the scoping and puts the gem into the production bundle. Also rebase contamination from gem-dashboards — please drop both dotenv-rails blocks (and the good_job line) from this PR; let Anthony's PR own them.
gobears01
force-pushed
the
enable-assignments
branch
from
a08b565 to
c5d961a
Compare
3 participants
General Info
Changes
On the coursers table, it would be nice if you could click enable or disable all assignments at once.
Testing
UI updates
Documentation
Does this PR require documentation. If so, explain where it can be found.
Checklist
enable-assignments branch to our fork