Open
Conversation
Filter done, skipped, and cancelled work-on-task refs before assignment creation, and stop all-terminal requests from producing assignments.
Update the root changelog and lockfile to capture the new release and its terminal-task filtering changes.
Record the follow-up notes and outcomes from the work-on-task filtering change.
Advance the task record to done now that the assignment workflow changes have landed.
7995f4c to
f67f315
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Reviewers and operators can now trust
work-on-taskassignment creation to handle terminal task refs cleanly, including no-oping when every requested ref is already terminal. Before this, terminal refs could leak into prepare/create flows and create avoidable assignment-generation churn for all-terminal requests. This update tightens the prepare/create contracts, aligns user-facing messaging/docs, and ships regression coverage so mixed/all-terminal inputs are handled deterministically.✏️ Changes
assign/prepareterminal filtering contract: resolves requested refs first, filtersdone/skipped/cancelled, continues mixed sets, and aborts all-terminal sets with explicit no-assignment messaging.assign/createall-terminal guardrails: blocks hidden-spec render andace-assign createwhen prepare returns only terminal refs; clarifies mixed-ref behavior uses filtered refs.work-on-taskinputs.WorkOnTaskTerminalFilterContractTestcoverage: validates prepare/create wording and usage docs against the shared terminal-status contract.ace-assignto0.38.2and recorded project/package changelog entries for the shipped increments.📁 File Changes
🧪 Test Evidence
WorkOnTaskTerminalFilterContractTest— validates terminal-status filtering language, mixed/all-terminal examples, create-flow all-terminal abort behavior, and usage-doc contract alignment.ace-test ace-assign— package suite passed with484 tests,1539 assertions,0 failures,0 errorsin5.63s.ace-assignlayer totals — atoms207, molecules66, organisms51, models76, commands84(all passing).📦 Releases
ace-assign v0.38.0— introduced explicitwork-on-taskdone-task filtering guidance in prepare/create workflows and docs.ace-assign v0.38.1— added regression coverage for mixed/all-terminal filtering and create-flow no-op behavior.ace-assign v0.38.2— aligned contracts to terminal statuses (done/skipped/cancelled) and moved contract coverage intotest/organisms/.project v0.9.926–0.9.928— recorded coordinated root changelog releases corresponding to the aboveace-assignincrements.