Skip to content

Conversation

@lisad
Copy link
Contributor

@lisad lisad commented Nov 26, 2025

I'm not sure whether these are going to be normative or not, but I worked up a schema for section 5 to start with

@glpatcern
Copy link
Member

Hi Lisa, great to see you starting on this, but it seems you may have not committed the schema itself or did I miss something?

@lisad
Copy link
Contributor Author

lisad commented Nov 28, 2025

I put a file called "ocm-discovery.json" inside a new folder called "schemas"? there will be several separate schemas if I continue with the rest of the spec. I made the schema a separate file for a number of reasons.

  1. it's easier for us not to screw up the syntax when editing it (trying to editing valid JSON inside MD is error-prone for me), we can even add a github test action to confirm schemas are valid
  2. folks will eventually be able to refer directly to these schemas when checking their implementations - some folks do this in CI/CD tests
  3. I wasn't sure we'd want to have them in the spec, but if we do, we can still import the schema into the spec - see for example how Rohan Mahy uses {::include} within https://github.com/rohanmahy/mimi-message-status/blob/main/draft-mahy-mimi-message-status.md to merge the schemas into the draft.

@MahdiBaghbani
Copy link
Member

@lisad I can see the file, but its contents are empty. Like Giuseppe, I assumed it hadn't been committed yet

@lisad
Copy link
Contributor Author

lisad commented Nov 29, 2025

Oh sorry I get it now! Fixed.

@glpatcern glpatcern self-requested a review December 1, 2025 08:37
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a very good direction for all the schemas! As a matter of fact, currently the schemas are declared in the OpenAPI spec.yaml file, but that's not linked in the Draft, and instead we can both link them and enforce them in CIs.

@glpatcern glpatcern merged commit 45c47fe into cs3org:develop Dec 2, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants