Skip to content

fix: read/write manifests with utf-8 encoding#15

Merged
csader merged 2 commits into
csader:mainfrom
InertiaImpact:fix/utf8-manifest-loading
May 5, 2026
Merged

fix: read/write manifests with utf-8 encoding#15
csader merged 2 commits into
csader:mainfrom
InertiaImpact:fix/utf8-manifest-loading

Conversation

@InertiaImpact
Copy link
Copy Markdown
Contributor

This pull request updates several file operations in server/app.py to explicitly specify UTF-8 encoding when opening files. This change improves compatibility and ensures proper handling of non-ASCII characters, especially when reading or writing JSON files.

This also fixes issues where encoding errors cause the settings cogs from rendering/being shown as well as potentially preventing whole apps from being displayed in the list.

File handling improvements:

  • Updated all open() calls for reading and writing JSON configuration and manifest files to use encoding='utf-8' in the following functions: load_settings, save_settings, load_installed_plugins, _load_channel_data, and app_library (server/app.py). [1] [2] [3] [4] [5]

@InertiaImpact
Copy link
Copy Markdown
Contributor Author

Should add, this fixes an encoding issue where non-standard characters show as garbled text, settings cog to not show, as well as sometimes prevent apps from being listed.

Before:
image
image

After:
image
image

@csader csader merged commit 017ff05 into csader:main May 5, 2026
@InertiaImpact InertiaImpact deleted the fix/utf8-manifest-loading branch May 8, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants