fix: read/write manifests with utf-8 encoding#15
Merged
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




This pull request updates several file operations in
server/app.pyto explicitly specify UTF-8 encoding when opening files. This change improves compatibility and ensures proper handling of non-ASCII characters, especially when reading or writing JSON files.This also fixes issues where encoding errors cause the settings cogs from rendering/being shown as well as potentially preventing whole apps from being displayed in the list.
File handling improvements:
open()calls for reading and writing JSON configuration and manifest files to useencoding='utf-8'in the following functions:load_settings,save_settings,load_installed_plugins,_load_channel_data, andapp_library(server/app.py). [1] [2] [3] [4] [5]