App/planes overhead#17
Merged
Merged
Conversation
Owner
|
Nice app! The code looks solid. Since PR #16 is now merged, this PR has duplicate changes in git fetch upstream
git rebase upstream/main
git push --force-with-lease origin app/Planes_OverheadAfter that we can merge cleanly. The only new files should be |
Keep provider polling state in-process and add OpenSky OAuth token fetch/caching so callers can supply client_id/secret for higher limits. Introduce polling rate logic and a settings signature to avoid unnecessary requests, broaden max_results limit, and cache flights between polls. Add robust provider error handling that maps timeouts, connection errors, auth failures, rate limits and server errors to user-facing pages. Update manifest defaults and UI: change refresh_interval, default location, radius, max results, dwell and polling defaults, mark some datasources with a note, and add opensky_client_id/opensky_client_secret settings (visible when using OpenSky).
65497d1 to
5ad4e8e
Compare
Contributor
Author
Should be rebased with just the 2 new files and the registry addition. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is reliant on #16 being merged first as it makes use of the advanced settings features introduced in that PR.
I can rebase if needed after #16 is merged if it will make things easier.
Planes Overhead App
This PR adds a comprehensive multi-provider aircraft tracking app to SplitFlap OS.
Features
Default location set to ORD Airport for high traffic example.
Implementation Details
Default provider is OpenSky with a anonymous API, settings will warn if you set refresh higher than your daily limit on the free tier.
Files
apps/planes_overhead/app.py— Provider clients, data parsing, formattingapps/planes_overhead/manifest.json— Settings schema with defaults and provider togglesapps/registry.json— App registration entry