Skip to content

Conversation

@jorenham
Copy link
Contributor

@jorenham jorenham commented Dec 5, 2024

Because according to the official typing spec:

For namespace packages (see PEP 420), the py.typed file should be in the submodules of the namespace, to avoid conflicts and for clarity.

Which makes sense in this case, as this project looks all nice and type-hinted 👌🏻

@csala
Copy link
Owner

csala commented Dec 5, 2024

@jorenham I just saw that codecov is making the workflow fail. I opened issue #7 to try to fix it.

But apart from this, pre-commit is failing due to end-of-file character. Would you mind sorting it out?

@jorenham
Copy link
Contributor Author

jorenham commented Dec 5, 2024

Hmm I thought the py.typed was required to be literally empty 🤔 But I'll add the newline anyway, as static type-checkers probably won't care about it anyway 👌🏻

@jorenham
Copy link
Contributor Author

jorenham commented Dec 5, 2024

Hmm I thought the py.typed was required to be literally empty 🤔 But I'll add the newline anyway, as static type-checkers probably won't care about it anyway 👌🏻

Oh huh apparently I misunderstood; pre-commit actually want to remove it 🤔

github's code editor officially sucks
@jorenham
Copy link
Contributor Author

jorenham commented Dec 5, 2024

GitHub's web editor messed it up again...
It should be fixed now.

@csala
Copy link
Owner

csala commented Dec 5, 2024

Thanks @jorenham Yes. The github editor is quick, but frequently not the best option 😅

I now fixed the codecov problem. Would you mind merging the main branch into yours, to fix it here?

@csala
Copy link
Owner

csala commented Dec 5, 2024

Screw it. Now codecov action fails because the token secret is not shared with an external PR.
I'm merging this anyway, since we know that it everything is alright, and I'll figure out the codecov thing for contributions separately.

@csala csala merged commit 22220f8 into csala:master Dec 5, 2024
6 of 13 checks passed
@jorenham jorenham deleted the py.typed branch December 5, 2024 15:07
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants