Skip to content

Code optimization #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
May 6, 2025
Merged

Code optimization #49

merged 37 commits into from
May 6, 2025

Conversation

@csboo
Copy link
Owner

@csboo csboo commented Mar 18, 2025

mostly clangd recommended optmiztaions
some other tweaks

@csboo csboo requested a review from jarjk March 18, 2025 23:48
csboo and others added 27 commits March 19, 2025 15:04
@csboo @jarjk
git: ingore meson files
31911d0
@csboo @jarjk
fix: enum -> enum class, with explicit base type
8e43db2
@csboo @jarjk
misc: format
0e45918
@csboo @jarjk
fix: an unsigned must be >= 0, assertion not needed
427fc42
@csboo @jarjk
fix: enum classes, most value now strictly static cast
5353a7d
@csboo @jarjk
fix: removed unused variable
0d17058
@csboo @jarjk
fix: properly ordered struct member initialization
7ebbfef
@csboo @jarjk
fix: marked function static
1268e7a
@csboo @jarjk
fix: enum -> enum class : uint8_t
286f020
@csboo @jarjk
fix: initialize draw type as a ref, with vec.at(), strict type case
b88bfb6
@csboo @jarjk
fix: unused var
29a6a6b
@csboo @jarjk
misc: use more parentheses for math expressions
c7e5814
@csboo @jarjk
fix: [nodiscard] is a c++17 extension
4eb064d
@csboo @jarjk
misc: use more parentheses for math expressions
81b0cac
@csboo @jarjk
fix: marked structs static
dbfcd51
@csboo @jarjk
misc: use more parentheses for math expressions
962ae57
@csboo @jarjk
fix: marked functions static
e00f9de
@csboo @jarjk
fix: marked some function static
a80aa83
@csboo @jarjk
fix: comment out unused var
9dbef13
@csboo @jarjk
fix: marked functions and objects static
3e50201
@csboo @jarjk
fix: static_cast most values
3317a82
@csboo @jarjk
fix: enum -> enum class : uint8_t
ce8be9e
@csboo @jarjk
fix: enum classes, most value now strictly static cast
a1a8a5f
@csboo @jarjk
fix: removed unused variable
f0db907
@csboo @jarjk
fix: marked function static
e135b0c
@csboo @jarjk
fix: unused var
af6dac4
@jarjk
refactor: satisfy clangd with many statics
da60c63
@jarjk
Copy link
Collaborator

jarjk commented Mar 19, 2025

rebased on main

@jarjk
Copy link
Collaborator

jarjk commented Mar 19, 2025 •
edited
Loading

FIXME: too much static

jarjk
jarjk approved these changes May 6, 2025
View reviewed changes
Copy link
Collaborator

@jarjk jarjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all right, nice

@jarjk jarjk merged commit d73549c into main May 6, 2025
7 checks passed
@jarjk jarjk deleted the code-opt branch May 6, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jarjk jarjk jarjk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csboo @jarjk