Revert "Change name of metadata directory"#36
Merged
Conversation
This reverts commit 88220cf. I made this change without fulling understanding it. This sets where the model_metadata package looks for the installed model metadata, so it shouldn't be changed.
Member
|
@mdpiper sorry, I should have caught this. As part of this pull request, would it be possible for you to add a test that checks that metadata files are installed correctly? |
Member
Author
|
@mcflugen I shouldn't have messed up! I'll make a test. |
Member
Author
|
@mcflugen Added test code. It's ugly, though; any suggestions for improvement are welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 88220cf, which fixes #35.
This statement gives the location of the installed model metadata. Changing it here in the babelizer causes problems downstream--it confuses the model_metadata package, which raises an exception from within pymt. I didn't fully understand the consequences of this change when I made it.