Skip to content
4 changes: 2 additions & 2 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ set(headers
)

if(USE_XMODULE) # Runtime Share Library interface - Not used since Version 0.899. (Windows only)
list(APPEND source XMODULE.CPP)
list(APPEND headers XMODULE.H)
list(APPEND source xmodule.cpp)
list(APPEND headers xmodule.h)
endif()

# Precompiled Headers
Expand Down
6 changes: 3 additions & 3 deletions src/RCDEF/rcdef.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -989,7 +989,7 @@ LOCAL void wdtypes( FILE *f)
// introductory info

fprintf( f,
"/* DTYPES.H: data types include file automatically generated by rcdef.exe. */\n"
"/* dtypes.h: data types include file automatically generated by rcdef.exe. */\n"
"\n"
" /* this file is #included in cnglob.h. */\n"
"\n"
Expand Down Expand Up @@ -1201,7 +1201,7 @@ LOCAL void wDttab() // write C++ source data types table dttab.cpp

// write front of file stuff
fprintf( f,
"/* DTTAB.CPP: data types table source file automatically generated by rcdef. */\n"
"/* dttab.cpp: data types table source file automatically generated by rcdef. */\n"
"\n"
" /* do not edit this file -- it is written over any time rcdef is run --\n"
" instead change the input, dtypes.def, and re-run rcdef.exe. */\n"
Expand Down Expand Up @@ -1439,7 +1439,7 @@ LOCAL void wUntab() // write untab.cpp

// head of file comments
fprintf( f,
"/* UNTAB.CPP: units table source file automatically generated by rcdef.exe. */\n"
"/* untab.cpp: units table source file automatically generated by rcdef.exe. */\n"
"\n"
" /* do not edit this file -- it is written over any time rcdef is run --\n"
" instead change the input, units.def, and re-run rcdef. */" );
Expand Down
2 changes: 1 addition & 1 deletion src/ancrec.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ typedef basAnc* BP; // basAnc pointer -- formerly used to localize NEARness
// class basAnc: base class for application record anchors.
//***************************************************************************************************************************
#define RTBRAT 0x2000 /* Old (1992) "Record Array Table" record type bit, now always on here, used in validity checks.
ALSO DEFINED IN SRD.H, MUST MATCH. */
also defined in srd.h, MUST MATCH!. */
//--- bits for basAnc.flags
#define RFSTAT 0x4000 // "static" record basAnc: not reallocable, min subscr 0 not 1. set ancrec.cpp, tested ancrec,cul,cuprobe.cpp.
#define RFTYS 0x1000 // is in TYPES sub-basAnc (pted to by a basAnc.tys)
Expand Down
2 changes: 1 addition & 1 deletion src/cnah1.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1107,7 +1107,7 @@ x TRUE may enable some autoSizing stuff eg in ztuMode. 7-20-95. */
return RCOK;
} // AH::ahCompute
//-----------------------------------------------------------------------------------------------------------------------------
// AH member functions called by ahEstimate, ahCompute, etc continue in CNAH2.CPP.
// AH member functions called by ahEstimate, ahCompute, etc continue in cnah2.cpp.
//-----------------------------------------------------------------------------------------------------------------------------

/******************************************************************************************************************************
Expand Down
2 changes: 1 addition & 1 deletion src/cncult4.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ LOCAL RC addRep( TI rfi, char *name, RPTYCH rpTy, TI zi, IVLCH freq, SI putAtEnd
rp->ownTi = rfi; // reference to report file
rp->rpTy = rpTy; // type of report
rp->rpFreq = freq; // 0 or frequency of report
rp->rpBtuSf = 1e6f; // energy print scale factor SHOULD MATCH DEFAULT IN CNCULT.C:rpT[] and exT[].
rp->rpBtuSf = 1e6f; // energy print scale factor SHOULD MATCH DEFAULT IN cncult.c:rpT[] and exT[].
rp->rpCond = 1; // make report print
rp->isExport = 0; // is report, not an export
rp->putAtEnd = putAtEnd; // put-after-user's-reports request. Only place set, 11-91.
Expand Down
2 changes: 1 addition & 1 deletion src/cnguts.h
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ extern SI cnRunSerial; // incremented in cgInit; copied to Topi.runSerial in c
extern VROUTINFO* UnspoolInfo; // dm array of info re unspooling virtual reports into actual report files.
// set up in cncult.cpp; format is for vrUnspool. vrpak.h struct.

//---------------------- CGSOLAR.CPP PUBLIC VARIABLE ------------------------
//---------------------- cgsolar.cpp PUBLIC VARIABLE ------------------------
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a tricky one. The file name is now consistent, but it is not consistent with the rest of the context here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that since all the titles are upper case it possibly needs to stay that way? or we can add quotes to imply that is a file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not saying it "needs" to be one way or the other. I'm just pointing out the new inconsistency you introduced and trying to understand why you came to the conclusion you did. I'm not saying it's wrong. Ultimately this specific case doesn't matter much at all. What really matters is that we are conscious of inconsistencies (even the more minor ones) and address them if possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a non-issue compared to the fact that we have comments that say PUBLIC VARIABLES and FUNCTION DECLARATIONS at all.

extern int slrCalcJDays[13]; // jDay for slr calcs or ausz DT decision for months 1-12. [0] for heat design day.


Expand Down
2 changes: 1 addition & 1 deletion src/cprint.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

/* CPRINT.H: printer defines used externally, for cprint.c
/* cprint.h: printer defines used externally, for cprint.c
CSE version derived from prpak.h 8-28-91 */


Expand Down
2 changes: 1 addition & 1 deletion src/cse.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// CSE.cpp : Main program module
// cse.cpp : Main program module
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our last iteration meeting, we touched upon the fact that the CSE executable name is in all caps, and maybe would remain that way. Does that argue for cse.h and cse.cpp to stay capitalized too? Obviously we can have CMake call the exe whatever we want, but in a simple build the file with main() would be the name of the binary.

// Defines entry points
///////////////////////////////////////////////////////////////////////////////

Expand Down
2 changes: 1 addition & 1 deletion src/cul.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4426,7 +4426,7 @@ LOCAL void FC NEAR clrBeenHeres( CULT *c)
} // clrBeenHeres


// ==================== CUL.CPP ERROR MESSAGE INTERFACES =====================
// ==================== cul.cpp error message interfaces =====================
// primarily for use from check-functions and run code, eg in cncult.cpp.
// Also error functions in cuparse.cpp and cutok.cpp are called directly. */
//-----------------------------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion src/dhwcalc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// DHWCalc.cpp -- Domestic Hot Water model implementation
// dhwcalc.cpp -- Domestic Hot Water model implementation
///////////////////////////////////////////////////////////////////////////////

#include "cnglob.h"
Expand Down
2 changes: 1 addition & 1 deletion src/dhwsolar.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// DHWSolar.cpp -- Solar Hot Water model implementation
// dhwsolar.cpp -- Solar Hot Water model implementation
///////////////////////////////////////////////////////////////////////////////

#include "cnglob.h"
Expand Down
2 changes: 1 addition & 1 deletion src/envpak.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

// ENVPAK.C: Environment specific routines -- Windows dependent
// envpak.c: Environment specific routines -- Windows dependent

/*------------------------------- INCLUDES --------------------------------*/
#include "cnglob.h"
Expand Down
2 changes: 1 addition & 1 deletion src/foundation.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// Foundation.cpp -- interface to Kiva
// foundation.cpp -- interface to Kiva
///////////////////////////////////////////////////////////////////////////////

#include "cnglob.h"
Expand Down
2 changes: 1 addition & 1 deletion src/foundation.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// Foundation.h -- interface to Kiva
// foundation.h -- interface to Kiva
///////////////////////////////////////////////////////////////////////////////

#if !defined( _FOUNDATION_H)
Expand Down
2 changes: 1 addition & 1 deletion src/geometry.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//==========================================================================
// Geometry.cpp -- contains different computational geomertic algoritms
// geometry.cpp -- contains different computational geomertic algoritms
//=============================================================================
// Copyright (c) 2014, ASHRAE.
// This work is a product of ASHRAE 1383-RP and draws on code
Expand Down
2 changes: 1 addition & 1 deletion src/impf.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

// IMPF.H header for Import Files for CSE 2-94
// impf.h header for Import Files for CSE 2-94


// largest field number to accept (expect far fewer fields in a file)
Expand Down
2 changes: 1 addition & 1 deletion src/messages.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ struct MSGTBL
// messages.cpp
void FC msgClean();
RC msgInit( int erOp);
const char* CDEC msg( char *mBuf, const char *mOrH, ...); // ALSO DECL IN CNGLOB.H
const char* CDEC msg( char *mBuf, const char *mOrH, ...); // ALSO DECL IN cnglob.h
RC msgI( int erOp, char* mBuf, size_t mBufSz, int* pMLen, const char* mOrH, va_list ap=NULL);
const char* FC msgSec( SEC sec);
BOO FC msgIsHan( const char* mOrH);
Expand Down
2 changes: 1 addition & 1 deletion src/srd.h
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ struct SFIR
Hi bits are attributes; lo are type #
Individual record types are defined in rctypes.h and are used in .rt, the 1st member of all record structures. */
#define RTBRAT 0x2000 /* "Record Array Table" type: has array of record structure in a DM block. See ancrec.h, .cpp.
ALSO DEFINED IN ANCREC.H, MUST MATCH. */
also defined in ancrec.h, MUST MATCH!. */
#define RTBHIDE 0x4000 // hide record: omit entire record from probe info report (CSE -p)
#ifdef wanted // define here if desired to test outside of rcdef.exe (rcdef defines internally ifndef, 12-91.)
w #define RTBSUB 0x8000 /* Substructure type definition, only for nesting in other record types
Expand Down
2 changes: 1 addition & 1 deletion src/xiopak.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

// XIOPAK.CPP: Extended IO and file functions
// xiopak.cpp: Extended IO and file functions

/* Department of further improvements (8-24-89) --

Expand Down
2 changes: 1 addition & 1 deletion src/xiopak.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license
// that can be found in the LICENSE file.

// XIOPAK.H: Definitions for extended IO package
// xiopak.h: Definitions for extended IO package

#if !defined( _XIOPAK_H)
#define _XIOPAK_H
Expand Down
2 changes: 1 addition & 1 deletion src/xmodule.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
// that can be found in the LICENSE file.

///////////////////////////////////////////////////////////////////////////////
// XMODULE.h -- interfaces to external DLL/EXE functions
// xmodule.h -- interfaces to external DLL/EXE functions
///////////////////////////////////////////////////////////////////////////////

#if !defined( _XMODULE_H)
Expand Down