Setpoint error check #462
Merged
Setpoint error check #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation: improve error checking of user input for znTC, znTD, and znTH. Incomplete error checking resulted in CSE run failures when CBECC generated incorrect input.
In the course of implementing the checking, it was discovered that record member status bytes were not being correctly copied when ZNI was copied to ZNR. (ZNR is an expanded variant of ZNI -- initial members are the same. Thus a "short" copy is used.) As noted in Issue #396, there have long been semi-duplicated functions record::Copy() and record::CopyFrom(). These have now been merged (into record::Copy()) and all uses changed as needed.
Documentation updated. A few test cases updated.