Correct day of week during warmup #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto warmup-jan1DOW-fix Due to minor conflict fixed on github in file dhwloop32U.rep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct the derivation of day of week during warmup that occurs in the year prior to the main simulation. This is a common case -- when the main simulation starts on Jan-1, the warmup period would typically be Dec-15 - Dec-31. With this fix, the expected day of week sequence is maintained over the Dec-31 -> Jan-1 boundary.
Also added a check on wuDays that limits it to 365 days.
Interestingly, this changed resulted in many regression differences, some surprisingly large. The cause of these changes turned out to be the relatively sloppy airnet tolerances typically used in CA compliance runs (anTolAbs = 0.03 and anTolRel = 0.003). This input was dropped from the regression input files (leaving the tolerances at the default anTolAbs = 0.00125 and anTolRel = 0.0001) and the regression differences were negligible. However, many regression files are updated.
Expanded documentation for wuDays and jan1DOW.