Add performance map based RSYS systems #490
Conversation
Merge from main.
| ASHPHYD "ASHPHydronic" | ||
| ASHPPKGRM "ASHPPkgRoom" | ||
| ASHPVC "VCHP2" | ||
| ASHPPM "ASHPPM|!VCHP3" |
There was a problem hiding this comment.
How does this work? I don't think I've seen this before?
There was a problem hiding this comment.
The choice scheme supports aliases. From cndtypes.def --
///////////////////////////////////////////////////////////////////////////////
// Choices: text <-> constant mapping
///////////////////////////////////////////////////////////////////////////////
// choice TEXT may specify aliases ("MAIN|ALIAS1|ALIAS2")
// choices may have TEXT beginning a prefix
// * = hidden (output only, not recognized on input)
// ! = alias (alternative wording for prior "real" choice
// ~ = deprecated alias (same as ! but info msg on input)
// else "normal"
// NOTE: only MAIN yields #define C_XXX_xxx
///////////////////////////////////////////////////////////////////////////////
src/CNRECS.DEF
Outdated
| *i CULSTR pmx_id // axis identifier (e.g. "DBT") | ||
| // cannot use PMGRIDAXIS.name | ||
| // multiple PMGRIDAXISs may use same pmx_id |
There was a problem hiding this comment.
I think we should call this "type" instead of "id"? "id" makes it sound like it's something the user can make up, but really it needs to match the types defined by the particular performance map use case.
src/CNRECS.DEF
Outdated
| *f *e FLOAT_GZ rs_COP115; // output: full speed cooling COP at 115F | ||
| *f *e FLOAT_GEZ rs_cap82; // output: total full speed net cooling capacity at 82 F (>= 0), Btuh | ||
| *f *e FLOAT_GZ rs_COP82; // output: full speed cooling COP at 82F | ||
| #if 0 |
src/cnloads.cpp
Outdated
| { // pre-2024 assumptions for non-ASHPPM types | ||
| // reverse-calc from prior hard-coded Btuh/ton values | ||
| float fanHeatPerTon = | ||
| #if 0 |
src/cnloads.cpp
Outdated
| #endif | ||
| rs_IsPkgRoom() ? 0.f // package room: no fan power adjustment | ||
| : rs_fan.fn_motTy == C_MOTTYCH_PSC ? 500. // PSC: .365 W/cfm | ||
| #if 1 |
src/cueval.cpp
Outdated
| return RCOK; | ||
| } // cupfree | ||
| //============================================================================ | ||
| #if 0 // out of service |
src/cueval.h
Outdated
| #endif | ||
| RC FC cuEvalR( void *ip, void **ppv, const char **pmsg, USI *pBadH); | ||
| RC FC cupfree( DMP *p); | ||
| #if 0 // out of service, 3-24 |
src/nummeth.cpp
Outdated
| return i; | ||
| } // ::regula | ||
| //----------------------------------------------------------------------------- | ||
| #if 0 |
There was a problem hiding this comment.
Clean up? What is this all about?
There was a problem hiding this comment.
Somebody's root finding method that I must have been fooling with. Deleted.
| // class PMGRIDAXIS: perfmap grid values (independent vars, e.g. DBT, speed, ) | ||
| // class PMLOOKUPDATA: perfmap performance data (e.g. capacity, power, ) | ||
| /////////////////////////////////////////////////////////////////////////////// | ||
| PMACCESS::PMACCESS() |
There was a problem hiding this comment.
This class should be renamed so it's clear it is specific to the RSYS use-case.
There was a problem hiding this comment.
Maybe. Wait for typed performance map redesign and see what falls out.
doc/src/records/performancemap.md
Outdated
| Documents the dimension of the axis, for example "DBT", "Speed", or "Flow". | ||
|
|
There was a problem hiding this comment.
Not just the dimension, but the actual grid variable (since, for example, multiple axes might be dry bulb temperatures). "DBT" should be changed to "OutdoorDryBulbTemperature" (or something similar).
Description
Support for revised variable speed heat pump model, including