Eliminate strpak.h charTypeErr scheme #504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chipbarnaby, have you confirmed that the "W" variants are still needed in some cases? Doesn't have to hold this up, but if you have maybe we can get rid of them all together? I was never able to reproduce the issue described in these comments. |
nealkruis
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Eliminate redefinition of ctype functions (e.g. isspace) to cause a compiler error. This scheme allowed detection of possibly incorrect use of such functions. However, downstream 3rd party #include files that use ctype functions could not be compiled. In particular, the Mac build failed due to this approach.
Also changed #include <ctype.h> to #include as in incremental step toward use of C++ headers as opposed to legacy C headers.
No results changes. No documentation changes.