Skip to content

Conversation

@nealkruis
Copy link
Contributor

@nealkruis nealkruis commented Feb 17, 2025

Description

User interface breaking changes:

  • FOUNDATION
    • Changed name of foundation wall construction from fdFtCon to fdWlCon (since it isn't really a footing)
    • fdFtCon is now required and defined separately from the ground-contact wall surface construction. The structural component of the wall that extends below the slab is now always defined by fdFtCon. Any furring, insulation, finishes on the interior are defined through the wall SURFACE construction (sfCon)
    • Change default foundation wall height above grade (fdWlHtAbvGrd) to be 6 inches (as the minimum allowed by many construction codes)
    • Change the definition of the foundation wall depth below the slab (fdWlDpBlwSlb) to be relative to the top of the slab floor, with a default equal to the floor SURFACE construction width (i.e., to the bottom of the slab).
  • FNDBLOCK (Foundation Blocks)
    • Change default second point X/Z references default to the same value as the first point X/Z references
  • SURFACE
    • Allow ground-contact floor and wall surfaces to have no construction (sfCon). This implies:
      • A floor without a construction is exposed directly to bare soil
      • A wall without a construction is exposed directly to the foundation wall construction (fdFtCon)

Fixes

  • Fixed issue where slab construction was using the wrong index (i.e., the slab construction was incorrect)
  • Fixed unit conversion issue for slab depth
  • Add error checking to ensure the bottom of the foundation wall is not above grade or above the bottom of the slab.

Internal changes

  • Move KIVA class outside of CNRECS
  • Better support for ground plot debugging (off by default; still something broken in MathGL memory)

Reviewer Checklist:

  • Read the pull request description
  • Perform a code review on GitHub
  • Confirm all CI checks pass and there are no build warnings
  • Pull, build, and run automated tests locally
  • Perform manual tests of the fix or feature locally
  • Add any review comments, if applicable
  • Submit review in GitHub as either
    • Request changes, or
    • Approve
  • Iterate with author until all changes are approved

Copy link
Contributor

@chipbarnaby chipbarnaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There might be a few places where "const whatever*" could be used instead of "whatever *"

@nealkruis nealkruis merged commit 9a1c95e into main Mar 12, 2025
4 checks passed
@nealkruis nealkruis deleted the update-mac-os-results branch March 12, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants