Fix large-draw bug (HPWHsim) #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2025 11:15
spahrenk
changed the title
spahrenk
changed the title
spahrenk
changed the title
chipbarnaby
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies HPWHsim to fix flawed calculation when the draw volume exceeds the tank volume. The case Vdraw > Vtank was formerly handled with separate code, which simplified the calculation by ignoring possible temperatures inversions in the tank. However, inversions are only to be expected when Tinlet > Ttank[0] (i.e., the bottom tank node), which is uncommon. (Perhaps the alternative code was introduced to improve computational speed.) Furthermore, separate algorithms for high and low draws can lead to discontinuities in the simulation results when Vdraw ~ Vtank. This PR applies the same algorithm (including possible inversion mixing) , regardless of draw volume.
The large-draw condition appears not to have been previously tested in HPWHsim. (Bug appear to have been introduced in balance-energy-hpwh) This PR adds energy-balance tests to check this case.