Add heating charge factor

[chipbarnaby]

Description

Generalized RSYS charge factor scheme.

• Added rsFChgH = heating compressor charge factor. Implemented in both "old" and PM models.
• Renamed rsFChg to rsFChgC = cooling compressor charge factor. (rsFChg is supported for backwards compatibility.)
• Modified implementation of charge factors to increase COP (or input power) rather than decrease capacity.

These changes results in smaller autosized capacities, but that is expected and has only a minor impact on energy results.

ALSO merged branch "modernize" that allows mapping of old to new probe names.

Small test results changes (due to autosizing differences). Reference files are reviewed and updated.

Documentation updated.

[nealkruis]

_strcmpi is not standard C++

[chipbarnaby]

You could fix this to keep things moving.

…

On Fri, Mar 28, 2025, 10:28 Neal Kruis ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/srd.h <#536 (comment)>: > +public: + MODERNIZEPAIR(const char* oldWord, const char* curWord) + : mp_oldWord{ oldWord }, mp_curWord{ curWord } + {} + bool mp_IsEnd() const + { + return mp_oldWord==nullptr; + } + bool mp_ModernizeIf( + const char* &word) const // word that may need modernizing + // e.g. from user input + // returned updated if needed + // returns true iff word modernized (word updated) + // else false + { + bool bMatch = _strcmpi(word, mp_oldWord) == 0; _strcmpi is not standard C++ — Reply to this email directly, view it on GitHub <#536 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACWGW7H4IF47CV6VWOXUZPD2WVMCFAVCNFSM6AAAAABZ57NXSWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOMRVG4ZTSMJWHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>