Window solar gain accounting / ACCUMULATOR improvements #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealkruis
reviewed
Sep 12, 2025
src/CNRECS.DEF
Outdated
Comment on lines
1379
to
1380
| *s *e FLOAT xs_glzTrans // ASHWAT windows: transmitted solar gain, Btuh (w/o cavity absorp adjustment) | ||
| *s *e FLOAT xs_glzInward // ASHWAT windows: inward flowing convective and LW radiant gain to zone, Btuh |
There was a problem hiding this comment.
Units should be Btu/h-ft2, no?
src/CNRECS.DEF
Outdated
| FLOAT acmMean // mean value seen in interval | ||
| FLOAT acmMax // max value seen in interval | ||
| FLOAT acmTotal // sum of values in interval | ||
|
|
There was a problem hiding this comment.
Add:
- Time of min
- Time of max
|
Can we also add a warning when a higher frequency probe is used in a lower frequency application (and using the last set value)? I don't think this is ever intentional and now with accumulators shouldn't be necessary. |
nealkruis
reviewed
Sep 19, 2025
nealkruis
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional XSURF probes to support details per-surface solar gains
ACCUMULATOR improvements
Accumulators currently have evaluation order issues, use with caution. Run test case(s) and check for lagged values.