Skip to content

Conversation

@Varun-Sethu
Copy link
Member

This is an absolutely quick and hacky database migrations, it deletes all tables and rebuilds them, in the future we will use a proper migration tool but this should suffice to get staging up and running

@Varun-Sethu Varun-Sethu requested a review from a team as a code owner September 26, 2022 10:27
@Varun-Sethu Varun-Sethu requested a review from angary September 26, 2022 10:27
@Varun-Sethu Varun-Sethu changed the title Database Migration Tool feat(cms): Database Migration Tool Sep 26, 2022
Copy link
Member

@angary angary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, try not to do except: pass + tests failing + L

Copy link
Member

@lhjt lhjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to push a few changes so that this image is created by the CI pipelines. Just a few comments to look at; I'll merge this in once I've added the relevant CI changes.

@lhjt lhjt changed the title feat(cms): Database Migration Tool feat(cms): database migration tool Sep 26, 2022
@lhjt lhjt added github_actions Pull requests that update GitHub Actions code database labels Sep 26, 2022
Copy link
Member

@lhjt lhjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I'll let you know once I edit the deployment manifests so that this is live.

@lhjt lhjt merged commit cb21a47 into main Sep 26, 2022
@lhjt lhjt deleted the varun/dbMigration branch September 26, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

database github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants