-
Notifications
You must be signed in to change notification settings - Fork 3
feat(start): timeline component, scroll animations #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zax-xyz
commented
Dec 24, 2022

set non-focused views to hidden for accessibility
lauraw0
pushed a commit
that referenced
this pull request
Feb 3, 2023
* template for starter guide * removed empty file * reduced padding of main container * feat(start): timeline component, scroll animations (#307) * feat(timeline): basic styling * refactor(Timeline): extract styled components into own module * refactor(timeline): move timeline inside MainContainer * feat(timeline): onClick handlers, active styles * feat(start): animate between pages * fix(start): current page animation * fix(timeline): key * refactor(timeline): use name * refactor(timeline): use function component * feat(timeline): circle color transition * feat(timeline): active button style * refactor(timeline): use implicit return in arrow function * feat(start): view aria-hidden set non-focused views to hidden for accessibility * feat(timeline): focus styles, keyboard navigation * fix(timeline): off by one errors 🤡 * feat(start): aria attributes accessibility :D * feat(timeline): mobile responsiveness * refactor: no vw, remove padding on small screens * Starter Guide - Enrolment Component (#306) * features added in enrolment view * completed enrolment features * added links to resources on hover * fix: mobile responsiveness * chore: remove yarn.lock Co-authored-by: Leonard Chiang <z5311740@student.unsw.edu.au> Co-authored-by: Michael Vo <zax@zaxu.xyz> * CSESoc Start - Advice Page (#310) * save * rough layout * converted to style components * mobile responsive * addedd pictures * swapped mobileS to base styling * fix(advice): expand to fill Co-authored-by: Michael Vo <zax@zaxu.xyz> * Start main welcome (#311) * basic countdown working. need to style * welcome view * made requested changes * timelinescroll set to x direction and fixed scroll for enrolment view on mobile * Start main enrolment (#313) * features added in enrolment view * completed enrolment features * added links to resources on hover * updated links to open in new tabs and updated enrolment guide banner to latest version --------- Co-authored-by: Winnie Tan <winnietan202@gmail.com> Co-authored-by: Leonard Chiang <z5311740@student.unsw.edu.au> * added future students menu header to hamburger menu on mobile view * Start Events Page (#312) * added events page components * added responsiveness * feat(start): connect page (#314) --------- Co-authored-by: Michael Vo <zax@zaxu.xyz> Co-authored-by: winnteas <89847626+winnteas@users.noreply.github.com> Co-authored-by: Leonard Chiang <z5311740@student.unsw.edu.au> Co-authored-by: Winnie Tan <winnietan202@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.