Skip to content

Conversation

@derek-ht
Copy link
Contributor

@derek-ht derek-ht commented Mar 4, 2023

Why the changes are required?

When creating a new file/folder the popup modal does not accept the enter key press to submit. Handling the enter key press provides better accessibility.

Changes

  • added an onKeyDown event to the submission textfield in ConfirmationWindow.tsx
  • created the event handler (handleKeyDown) that calls handleSubmit when pressed

Screenshots

Comments

@derek-ht derek-ht requested review from jamest0 and lauraw0 as code owners March 4, 2023 08:05
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm you can merge now! :D

@derek-ht derek-ht merged commit 19c41b9 into main Mar 5, 2023
@derek-ht derek-ht deleted the WEB-10_handle_enter_key branch March 5, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants