Skip to content

remove input box when user deselects the title of a folder or a file #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
winnteas merged 2 commits into from
Mar 16, 2023
Merged

remove input box when user deselects the title of a folder or a file #338

winnteas merged 2 commits into from
Mar 16, 2023

Conversation

@winnteas
Copy link
Contributor

@winnteas winnteas commented Mar 12, 2023

Why the changes are required

  • the input box persists and the user may end up with multiple input boxes for changing the names of the files and folders

Changes

  • the input box is automatically focused once the name is double clicked
  • clicking outside the box will set the name

lauraw0
lauraw0 approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@winnteas winnteas merged commit 6455e3b into main Mar 16, 2023
@winnteas winnteas deleted the WEB11-remove-input-box-deselect branch March 16, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamest0 jamest0 Awaiting requested review from jamest0

1 more reviewer

@lauraw0 lauraw0 lauraw0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@winnteas @lauraw0