Skip to content

Conversation

@brian2w
Copy link
Contributor

@brian2w brian2w commented Mar 25, 2023

Why the changes are required?

Breadcrumb pill path was not interactive and did not allow user to traverse the folder structure by clicking on it.
Repeatedly clicking on the root folder also caused the path to repeatedly print out 'root'.

Changes

  • Implemented breadcrumb pill clicking functionality by altering how path was stored: string path -> array of objects storing folderId and folderNames
  • Using the above change to an array, the repeating root in path was also fixed by checking if a certain folderId already existed in the path array.

Screenshots

Comments

Now that the path is stored in an array of objects, the traverseBackFolderSaga can simply be replaced by traverseIntoFolderSaga, so can potentially be removed.

brian2w added 4 commits March 11, 2023 00:19
… using ids on pathList, corrected display of files when navigating back to root directory after exiting file view
@brian2w brian2w requested review from jamest0 and lauraw0 as code owners March 25, 2023 07:21
@brian2w brian2w self-assigned this Mar 25, 2023
Copy link
Contributor

@lauraw0 lauraw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! merge whenever :)

@brian2w brian2w merged commit 8c089e5 into main Apr 6, 2023
@brian2w brian2w deleted the WEB-20_clicking_on_folder_pill_in_path_redirects_user_to_that_folder branch April 6, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants