Resolve #41 - version 2 of the library#42
Merged
craigfowler merged 33 commits intomasterfrom Jun 4, 2024
Merged
Conversation
This isn't finished yet, it's really just the beginning of the work.
The type loading logic is now a separate service.
Except for integration tests!
Upgrade to VS 2022 & remove redundant config
Use dotnet build/test instead of msbuild
It's all redundant now I've replaced it.
…riverExtras into feature/41-version2
Also, add DI registrations for the services produced so far.
Having just one options instance shared is problematic, because many WebDrivers will be created, each requiring slight modifications of those options instances. It's best to use one non-reusable options instance per WebDriver, rather than trying to reuse one instance for many drivers.
Provisionally, this is all done now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.