Skip to content

Improves Resilience From Missing Steam Response Fields #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Improves Resilience From Missing Steam Response Fields #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/alarms/trade_history.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ async function getTradeHistoryFromAPI(): Promise<TradeHistoryStatus[]> {
}

const data = (await resp.json()) as TradeHistoryAPIResponse;
return data.response.trades
return (data.response?.trades || [])
.filter((e) => e.status === 3) // Ensure we only count _complete_ trades (k_ETradeStatus_Complete)
.filter((e) => !e.time_escrow_end || new Date(parseInt(e.time_escrow_end) * 1000).getTime() < Date.now())
.map((e) => {
Expand Down
6 changes: 3 additions & 3 deletions src/lib/alarms/trade_offer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ async function getSentTradeOffersFromAPI(): Promise<OfferStatus[]> {
}

const data = (await resp.json()) as TradeOffersAPIResponse;
return data.response.trade_offers_sent.map(offerStateMapper);
return (data.response?.trade_offers_sent || []).map(offerStateMapper);
}

async function getSentAndReceivedTradeOffersFromAPI(): Promise<{
Expand All @@ -260,8 +260,8 @@ async function getSentAndReceivedTradeOffersFromAPI(): Promise<{

const data = (await resp.json()) as TradeOffersAPIResponse;
return {
received: data.response.trade_offers_received.map(offerStateMapper),
sent: data.response.trade_offers_sent.map(offerStateMapper),
received: (data.response?.trade_offers_received || []).map(offerStateMapper),
sent: (data.response?.trade_offers_sent || []).map(offerStateMapper),
steam_id: access.steam_id,
};
}
Expand Down
Loading