Skip to content

Conversation

@GODrums
Copy link
Collaborator

@GODrums GODrums commented Feb 1, 2025

Motivation

Fixes #243.

Description

With this PR we want to start supporting Firefox-based browsers for the new versions of the extension again. To achieve this, this PR changes:

  • New popup exclusive to the Firefox version to provide an option of requesting the required Steam permissions as the BetterTracking-widget doesn't work in Firefox
  • Adjust declarativeNetRequest-rules according to Firefox's random IDs
  • Change minimum Firefox version to 127.0 to guarantee permissions listed in host_permissions are granted on install (source: https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/)
  • Chore: update @types/chrome to 0.0.300 to successfully use async/await on chrome.permissions-methods

Possible TODOs:

  • Adjust the BetterTracking "Enable"-button for Firefox to refer to the popup (automatic opening not possible in Firefox)
  • Further popup features:
    • Error state for popup in case of a permission deny
    • More detailed permission status
    • Explanatory text / links / CSFloat socials

Screenshots

Popup with missing permissions:
image
Popup with granted permissons:
image

@GODrums GODrums requested a review from Step7750 February 1, 2025 02:05
@GODrums GODrums self-assigned this Feb 1, 2025
Copy link
Member

@Step7750 Step7750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @GODrums, Firefox users shall rejoice!

Copy link
Member

@Step7750 Step7750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost forgot, I believe we may need to hide the enable offer tracking banner that Chrome gets (or replace it with something that tells them to open the extension popover in the top right).

AFAIK, we cannot programmatically open the extension popover (if we can, that'd be preferrable). I'll add custom instructions for FF users in the front-end.

@GODrums
Copy link
Collaborator Author

GODrums commented Feb 13, 2025

@Step7750
Those are very good points! I adjusted the button in the following way now:

  • Change text to "Enable in the Extension Popup"
  • Switch the button to Steam's grey button design + make it disabled:
    Screenshot 2025-02-13 034319
  • On click, the user gets a popup to use the extension popup instead:
    Screenshot 2025-02-13 040247

Let me know what you think of these changes.

Copy link
Member

@Step7750 Step7750 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GODrums and others added 2 commits February 14, 2025 21:44
Co-authored-by: Step7750 <Step7750@gmail.com>
@GODrums GODrums merged commit eb36ba4 into master Feb 14, 2025
2 checks passed
@GODrums GODrums deleted the fix/full-firefox-support branch February 14, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Support Extension on Firefox

3 participants