- 
                Notifications
    
You must be signed in to change notification settings  - Fork 33
 
Fix: Compatibility issues for Firefox #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Firefox has random IDs, so we have to make a dynamic rule instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GODrums, Firefox users shall rejoice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost forgot, I believe we may need to hide the enable offer tracking banner that Chrome gets (or replace it with something that tells them to open the extension popover in the top right).
AFAIK, we cannot programmatically open the extension popover (if we can, that'd be preferrable). I'll add custom instructions for FF users in the front-end.
| 
           @Step7750 
 Let me know what you think of these changes.  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Step7750 <Step7750@gmail.com>


Motivation
Fixes #243.
Description
With this PR we want to start supporting Firefox-based browsers for the new versions of the extension again. To achieve this, this PR changes:
host_permissionsare granted on install (source: https://extensionworkshop.com/documentation/develop/manifest-v3-migration-guide/)@types/chrometo0.0.300to successfully use async/await onchrome.permissions-methodsPossible TODOs:
Screenshots
Popup with missing permissions:


Popup with granted permissons: