Skip to content

Implements Background Rollback Notary Proofs#368

Merged
Step7750 merged 4 commits intomasterfrom
feature/background-rollback-notary-proof
Mar 5, 2026
Merged

Implements Background Rollback Notary Proofs#368
Step7750 merged 4 commits intomasterfrom
feature/background-rollback-notary-proof

Conversation

@Step7750
Copy link
Member

@Step7750 Step7750 commented Mar 4, 2026

Ref CSF-1105


Note

Medium Risk
Changes the rollback-trade handling path to optionally generate and submit notary proofs, adding new network calls and feature-flagged behavior with a legacy fallback. Risk is moderate due to new API dependencies and potential failure modes around proving/token fetching.

Overview
Rollback handling now supports background notary proofs. When rollback trades are detected, pingRollbackTrades can (if enabled via /v1/meta/notary and not Firefox) fetch a notary token, prove relevant trade history via NotaryProve, and submit the proof to /v1/trades/notary instead of sending the legacy rollback ping.

If background proving fails, the code reports the error to /v1/trades/:tradeId/report-error and falls back to the existing PingRollbackTrade flow. This also centralizes the trade-history fetch limit via MAX_TRADE_HISTORY_FETCH and wires new bridge handlers FETCH_NOTARY_META/FETCH_NOTARY_TOKEN into the request handler map.

Written by Cursor Bugbot for commit a4b267a. This will update automatically on new commits. Configure here.

@Step7750 Step7750 requested a review from GODrums March 4, 2026 02:19
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Copy link
Collaborator

@GODrums GODrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Step7750 Step7750 merged commit 9d99fb3 into master Mar 5, 2026
3 checks passed
@Step7750 Step7750 deleted the feature/background-rollback-notary-proof branch March 5, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants