Merged
Conversation
This reverts commit 9e78e47.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Step7750
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CSF-884
Closes CSF-876
Refs CSF-881
Note
Medium Risk
Adds a new authenticated DELETE endpoint that permanently deletes API keys; mistakes in the ownership/environment checks or transaction handling could allow unintended deletions or block legitimate ones.
Overview
Adds marketplace support for deleting API keys via
DELETE /keys/{id}.The new handler performs deletion inside a private DB transaction and enforces safety checks (same marketplace slug, same environment, and disallows deleting the key currently used for authentication), with improved error logging/response mapping.
Expands test coverage significantly for the delete flow (middleware/auth/permissions, bad inputs, ownership/env mismatch, and context errors) and adds shared test helpers in
internal/testutilfor creating a marketplace+key and building authenticated requests.Written by Cursor Bugbot for commit 896012e. This will update automatically on new commits. Configure here.