Skip to content

Marketplace Delete Keys#31

Merged
hayesZach merged 28 commits intomasterfrom
feature/delete-keys-for-marketplace
Feb 9, 2026
Merged

Marketplace Delete Keys#31
hayesZach merged 28 commits intomasterfrom
feature/delete-keys-for-marketplace

Conversation

@hayesZach
Copy link
Copy Markdown
Collaborator

@hayesZach hayesZach commented Feb 6, 2026

Closes CSF-884
Closes CSF-876
Refs CSF-881


Note

Medium Risk
Adds a new authenticated DELETE endpoint that permanently deletes API keys; mistakes in the ownership/environment checks or transaction handling could allow unintended deletions or block legitimate ones.

Overview
Adds marketplace support for deleting API keys via DELETE /keys/{id}.

The new handler performs deletion inside a private DB transaction and enforces safety checks (same marketplace slug, same environment, and disallows deleting the key currently used for authentication), with improved error logging/response mapping.

Expands test coverage significantly for the delete flow (middleware/auth/permissions, bad inputs, ownership/env mismatch, and context errors) and adds shared test helpers in internal/testutil for creating a marketplace+key and building authenticated requests.

Written by Cursor Bugbot for commit 896012e. This will update automatically on new commits. Configure here.

@hayesZach hayesZach self-assigned this Feb 6, 2026
@hayesZach hayesZach added the Enhancement New feature or request label Feb 6, 2026
@hayesZach hayesZach marked this pull request as ready for review February 6, 2026 01:12
@linear
Copy link
Copy Markdown

linear bot commented Feb 6, 2026

Base automatically changed from feature/atomic-transaction to master February 6, 2026 18:43
@hayesZach hayesZach requested a review from Step7750 February 6, 2026 20:50
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@hayesZach hayesZach merged commit cb4a982 into master Feb 9, 2026
2 checks passed
@hayesZach hayesZach deleted the feature/delete-keys-for-marketplace branch February 9, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants