Skip to content

wrap array with double quotes#57

Merged
hayesZach merged 1 commit intomasterfrom
fix/wrap-with-string
Mar 16, 2026
Merged

wrap array with double quotes#57
hayesZach merged 1 commit intomasterfrom
fix/wrap-with-string

Conversation

@hayesZach
Copy link
Copy Markdown
Collaborator

@hayesZach hayesZach commented Mar 16, 2026

Note

Low Risk
Low risk config-only change that adjusts how a single env var is parsed at deploy time. Risk is limited to CORS/origin allowlist behavior if the consuming app expects the previous unquoted format.

Overview
Updates deploy/reverse-watch-service.yaml to wrap the HTTP_ALLOWEDORIGINS array-like value in double quotes so it is treated as a string rather than a YAML sequence.

Written by Cursor Bugbot for commit 710b52f. This will update automatically on new commits. Configure here.

@hayesZach hayesZach merged commit c10ddb3 into master Mar 16, 2026
3 checks passed
@hayesZach hayesZach deleted the fix/wrap-with-string branch March 16, 2026 22:07
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

value: https://csfloat.com
- name: HTTP_ALLOWEDORIGINS
value: ['chrome-extension://jjicbefpemnphinccgikpdaagjebbnhg']
value: "['chrome-extension://jjicbefpemnphinccgikpdaagjebbnhg']"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CORS origin value contains extraneous brackets and quotes

High Severity

The HTTP_ALLOWEDORIGINS env var is now set to the literal string ['chrome-extension://jjicbefpemnphinccgikpdaagjebbnhg'], including brackets and single quotes. Viper/mapstructure will parse this into a []string containing that entire literal (brackets and all) as a single element. In server.go, the CORS check does an exact string comparison (allowedOrigin == origin), so it will never match the actual Chrome extension origin chrome-extension://jjicbefpemnphinccgikpdaagjebbnhg, effectively blocking all Chrome extension requests.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant