Skip to content

Feat/data model#174

Merged
isabeleliassen merged 13 commits intocsg-org:developmentfrom
InspiringApps:feat/data-model
Aug 28, 2024
Merged

Feat/data model#174
isabeleliassen merged 13 commits intocsg-org:developmentfrom
InspiringApps:feat/data-model

Conversation

@jusdino
Copy link
Contributor

@jusdino jusdino commented Aug 26, 2024

Description List

  • Updated data model to reflect latest understanding
  • Official first API version (v1)
  • Updated lambda authorization logic to tie staff permissions with data access

Testing List

  • Code review
  • I'm happy to do a demo if needed

Closes #
#84

@jlkravitz
Copy link
Collaborator

jlkravitz commented Aug 26, 2024

  • review the pull request to get oriented
    • read the description of the pull request, which should summarize the changes made
    • read through every task on the Scrum board that's encompassed by this pull request
    • read the description of the commits that comprise the pull request
  • skim all new code, in the context of existing code, looking for problems (knowing that the vast majority of new code will be covered by tests)
  • review all tests
    • methodically review all new tests for correctness, quality of naming
    • look at code coverage of tests
    • determine what code isn’t tested, review that rigorously
  • review documentation to ensure that it matches changes
  • provide comments on the pull request on GitHub, as necessary
    • for comments that are specific to a particular line of code, comment on those specific lines
    • for comments that are more general, attach the comment to a random line in README.md (as opposed to commenting on the pull request itself), to be able to use GitHub's ability to thread discussions on those comments
  • run a security audit of dependencies (e.g. npm audit and pip audit) to ensure that there are no vulnerabilities that will be deployed to production (as opposed to vulnerabilities that only have an impact on the development environment)

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! What an adventure. Great work on this generally: really thorough testing and documentation. Lots of little questions and nits, but hopefully we can get through them quickly tomorrow (Tuesday).

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen This is good to merge!

@isabeleliassen isabeleliassen merged commit 985ef65 into csg-org:development Aug 28, 2024
@jusdino jusdino deleted the feat/data-model branch October 14, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants