Merged
Conversation
Collaborator
|
jlkravitz
reviewed
Aug 27, 2024
Collaborator
jlkravitz
left a comment
There was a problem hiding this comment.
Woo! What an adventure. Great work on this generally: really thorough testing and documentation. Lots of little questions and nits, but hopefully we can get through them quickly tomorrow (Tuesday).
...-connect/lambdas/license-data/tests/function/test_data_model/test_license_transformations.py
Show resolved
Hide resolved
backend/compact-connect/lambdas/provider-data-v1/tests/bin/generate_mock_data.py
Show resolved
Hide resolved
backend/compact-connect/stacks/api_stack/v1_api/query_providers.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/stacks/api_stack/v1_api/query_providers.py
Outdated
Show resolved
Hide resolved
backend/compact-connect/stacks/api_stack/v1_api/query_providers.py
Outdated
Show resolved
Hide resolved
jlkravitz
approved these changes
Aug 28, 2024
Collaborator
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen This is good to merge!
isabeleliassen
approved these changes
Aug 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description List
Testing List
Closes #
#84