Skip to content

Frontend/migrate to v1 api#184

Merged
isabeleliassen merged 7 commits intocsg-org:developmentfrom
InspiringApps:frontend/migrate-to-v1-api
Sep 6, 2024
Merged

Frontend/migrate to v1 api#184
isabeleliassen merged 7 commits intocsg-org:developmentfrom
InspiringApps:frontend/migrate-to-v1-api

Conversation

@jsandoval81
Copy link
Collaborator

@jsandoval81 jsandoval81 commented Aug 30, 2024

Requirements List

  • None

Description List

  • Updated frontend License & Licensee models for latest API response structure
  • Updated network endpoints to use v1 paths
  • Added a Compact model for better support of multi-compact cases
    • Was also able to simplify the StateUpload component as a result
  • UI component updates to support model updates
  • Pagination updates to support the current state of server paging
    • Commented out some items that are still WIP in backend; such as "previous" button support
  • Small update to more modern <meta> prop in index.html
  • Updated local offline mock API
  • Address a11y duplicate ID issue
  • Add keyboard nav to provider list

Testing List

  • yarn test:unit:all
  • yarn serve
  • yarn build
  • Code review

Closes #145
Closes #142

@jlkravitz
Copy link
Collaborator

jlkravitz commented Aug 30, 2024

  • review the pull request to get oriented
    • read the description of the pull request, which should summarize the changes made
    • read through every task on the Scrum board that's encompassed by this pull request
    • read the description of the commits that comprise the pull request
  • skim all new code, in the context of existing code, looking for problems (knowing that the vast majority of new code will be covered by tests)
  • review all tests
    • methodically review all new tests for correctness, quality of naming
    • look at code coverage of tests
    • determine what code isn’t tested, review that rigorously
  • review documentation to ensure that it matches changes
  • provide comments on the pull request on GitHub, as necessary
    • for comments that are specific to a particular line of code, comment on those specific lines
    • for comments that are more general, attach the comment to a random line in README.md (as opposed to commenting on the pull request itself), to be able to use GitHub's ability to thread discussions on those comments
  • run a security audit of dependencies (e.g. npm audit and pip audit) to ensure that there are no vulnerabilities that will be deployed to production (as opposed to vulnerabilities that only have an impact on the development environment)

@jsandoval81 jsandoval81 mentioned this pull request Sep 3, 2024
23 tasks
Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few small nits.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small nits and a couple unresolved comments above but otherwise looks great. thank you!

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge this!

@isabeleliassen isabeleliassen merged commit f738ec9 into csg-org:development Sep 6, 2024
@jsandoval81 jsandoval81 deleted the frontend/migrate-to-v1-api branch November 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend implementation of v1 API From Sprint 5: Duplicate id attribute "app"

3 participants