Feat/ Add endpoint for purchasing privileges by landonshumway-ia · Pull Request #272 · csg-org/CompactConnect

landonshumway-ia · 2024-10-23T16:02:37Z

This PR includes a new endpoint POST /v1/purchases/privileges which takes in a list of jurisdictions that a provider has
selected to purchase, as well as card billing information, to process a transaction using the compact's payment processor
of choice.

After the transaction is successfully completed, this endpoint then adds the associated privilege records under the provider's list of privileges.

We also have another ticket for adding an endpoint to store these authorize.net credentials securely in secrets manager. See #267

Requirements List

Until we complete Compact Admins can upload their authorize.net credentials for processing transactions #267, these authorize.net credentials will need to be stored manually in secrets manager in order to test this endpoint in a specific AWS account.

Description List

Added POST /v1/purchases/privileges with lambda handler and tests

Testing List

yarn test:unit:all should run without errors or warnings
yarn serve should run without errors or warnings
yarn build should run without errors or warnings
For API configuration changes: CDK tests added/updated in backend/compact-connect/tests/unit/test_api.py
Code review

Closes #261

We need to fetch the provider record in order get their military status, so this brings in all the schema files that are needed in order to load the records. Also updated the common test files to upload this data.

This fetches all the jurisdiction configuration for the jurisdictions a user has selected to buy privileges in and sends that information to the purchase client to process the charge to their card.

landonshumway-ia · 2024-10-23T16:38:19Z

@jusdino The tests are failing due to an import error, which I can't figure out:

ModuleNotFoundError: No module named 'authorizenet'

I have the dependency included in the requirements.in file here So I'm not sure why the test runner can't find the module.

This handles creating the records if the transaction is successful as well as voiding the transaction if the privilege records cannot be created for whatever reason.

Improves type safety and makes fields read-only

jusdino

Phew! Good work! I've got a few thoughts to ponder on this one:

backend/compact-connect/lambdas/purchases/handlers/privileges.py

backend/compact-connect/lambdas/purchases/data_model/schema/compact.py

backend/compact-connect/lambdas/purchases/handlers/privileges.py

backend/compact-connect/stacks/api_stack/v1_api/purchases.py

backend/compact-connect/tests/unit/test_purchases_api.py

backend/compact-connect/lambdas/purchases/data_model/client.py

- enforcing valid jurisdiction check at APIGW level - setting min and max lengths for API values - Fix secret arn to include required * - checking for best matching license - rename variables - update exception type

jusdino

Great!

landonshumway-ia · 2024-10-29T16:53:59Z

@jlkravitz This PR is now ready for CSG review

jlkravitz · 2024-10-29T17:54:49Z

jlkravitz

a few comments but generally looks great! thanks for the thorough testing!

backend/compact-connect/lambdas/provider-data-v1/data_model/schema/privilege.py

backend/compact-connect/lambdas/purchases/handlers/privileges.py

backend/compact-connect/lambdas/purchases/purchase_client.py

backend/compact-connect/lambdas/purchases/tests/function/__init__.py

...d/compact-connect/lambdas/purchases/tests/function/test_handlers/test_purchase_privileges.py

backend/compact-connect/lambdas/purchases/tests/unit/test_purchase_client.py

jlkravitz

@isabeleliassen good to merge!

landonshumway-ia added 13 commits October 21, 2024 17:07

WIP - adding Payment processor utils

d373944

Payment processor for authorize.net transactions

d516ec0

Add military discount test case

3373404

Bring in common schema setup

cbb64b5

We need to fetch the provider record in order get their military status, so this brings in all the schema files that are needed in order to load the records. Also updated the common test files to upload this data.

Add handler for making privilege purchases

0fe5bea

This fetches all the jurisdiction configuration for the jurisdictions a user has selected to buy privileges in and sends that information to the purchase client to process the charge to their card.

Adding POST purchase privileges endpoint

9d051f7

Align request body format to match expected keys

21e1fde

Setting ENVIRONMENT_NAME for lambda env vars

8e30c78

Ruff formatting changes

173ecc3

Ruff linter fixes

08c2762

Return authorize.net failed transaction message to client

fbb864b

Fix invalid import

73f4177

linter

a84c918

landonshumway-ia requested review from carlsims, isabeleliassen and jlkravitz as code owners October 23, 2024 16:02

landonshumway-ia added 6 commits October 23, 2024 11:45

Add new lambda directories to sync deps

5e741bc

Update dependencies

a49a668

Creating privilege records after transaction

dae1303

This handles creating the records if the transaction is successful as well as voiding the transaction if the privilege records cannot be created for whatever reason.

Fix provider data tests to account for new compactTransactionId field

0665da6

Convert to UserDict collection

86e78b9

Improves type safety and makes fields read-only

line too long fixes

8f1cbcb

jusdino suggested changes Oct 25, 2024

View reviewed changes

landonshumway-ia added 5 commits October 28, 2024 09:00

Initial PR feedback

e45ea35

- enforcing valid jurisdiction check at APIGW level - setting min and max lengths for API values - Fix secret arn to include required * - checking for best matching license - rename variables - update exception type

formatting changes

3f01b2c

Add exceptional case testing

6dfd353

lint fixes

a317d8b

Update requirements to latest

332951e

landonshumway-ia requested a review from jusdino October 28, 2024 15:49

landonshumway-ia added 4 commits October 28, 2024 14:36

Make common Enum pattern

df8d955

format change

7eac5ea

using boto3 client instead of resource

b95fb15

More PR feedback

af6888d

jusdino approved these changes Oct 28, 2024

View reviewed changes

landonshumway-ia added 3 commits October 28, 2024 16:20

Fix - remove extra / as beginning of secret name

6dc815b

Cast decimal types to float for purchase calculations

0056028

Cast authorize.net transactionId to str

1184603

jlkravitz requested changes Oct 29, 2024

View reviewed changes

PR feedback

6624f79

landonshumway-ia requested a review from jlkravitz October 29, 2024 19:45

jlkravitz approved these changes Oct 29, 2024

View reviewed changes

isabeleliassen approved these changes Oct 30, 2024

View reviewed changes

isabeleliassen merged commit 8439ef9 into csg-org:development Oct 30, 2024

jusdino deleted the feat/purchase-request branch January 28, 2025 16:04

Conversation

landonshumway-ia commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Requirements List

Description List

Testing List

Uh oh!

landonshumway-ia commented Oct 23, 2024

Uh oh!

jusdino left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jusdino left a comment

Choose a reason for hiding this comment

Uh oh!

landonshumway-ia commented Oct 29, 2024

Uh oh!

jlkravitz commented Oct 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jlkravitz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlkravitz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

landonshumway-ia commented Oct 23, 2024 •

edited

Loading

jlkravitz commented Oct 29, 2024 •

edited

Loading