Frontend/a11y table voice nav#290
Merged
isabeleliassen merged 4 commits intocsg-org:developmentfrom Oct 30, 2024
Merged
Conversation
jlkravitz
approved these changes
Oct 30, 2024
Collaborator
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
looks good to me! I don't have a quick way to deploy and test individual PRs, so I'll run the original test I ran on the full-sprint PR but this generally looks like what we want.
Thanks for putting this together @isabeleliassen good to merge.
isabeleliassen
approved these changes
Oct 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #224