Skip to content

Frontend/account page#317

Merged
isabeleliassen merged 7 commits intocsg-org:developmentfrom
InspiringApps:frontend/account-page
Nov 12, 2024
Merged

Frontend/account page#317
isabeleliassen merged 7 commits intocsg-org:developmentfrom
InspiringApps:frontend/account-page

Conversation

@jsandoval81
Copy link
Collaborator

Requirements List

  • yarn install --ignore-engines

Description List

  • Add a UserAccount component
  • Add a ChangePassword component
  • Add an Account page component
  • Add an Account link to the main nav
  • Add update-staff-user call to the Data API
  • Add an OAuth scope to the staff users to allow authenticated password changes
  • Update some a11y on the existing InputPassword component
  • Minor updates for InputText and FormMixin components
  • Updated happy-dom dev dependency

Testing List

  • yarn install --ignore-engines
  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review
  • Staff users
    • Should be able to navigate to Account page
    • Should be able to change first name and last name
    • Should be able to see, but not edit email
    • Should be able to change password
  • Licensee users
    • Should be able to navigate to Account page
    • Should be able to see, but not edit first name, last name, email
    • Should be able to change password

Closes #194

@ChiefStief
Copy link
Collaborator

ChiefStief commented Nov 11, 2024

We also have some slight UI issues in mobile:

  1. Probably want to add a margin to the account title or padding to the page (the tablet view has the same issue vertically)
  2. The compact selector drop down and the hamburger icon run into each other, we may want a max width for the compact drop down
Screenshot 2024-11-11 at 1 42 06 PM

@jsandoval81
Copy link
Collaborator Author

@jlkravitz This is ready for your review.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Two small comments.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen This is good to go.

@isabeleliassen isabeleliassen merged commit 176a7d5 into csg-org:development Nov 12, 2024
landonshumway-ia pushed a commit to InspiringApps/JCC-CompactConnect that referenced this pull request Nov 15, 2024
### Requirements List
- `yarn install --ignore-engines`

### Description List
- Add a UserAccount component
- Add a ChangePassword component
- Add an Account page component
- Add an Account link to the main nav
- Add update-staff-user call to the Data API
- Add an OAuth scope to the staff users to allow authenticated password
changes
- Update some a11y on the existing InputPassword component
- Minor updates for InputText and FormMixin components
- Updated `happy-dom` dev dependency
    - https://github.com/csg-org/CompactConnect/security/dependabot/53

### Testing List
- `yarn install --ignore-engines`
- `yarn test:unit:all` should run without errors or warnings
- `yarn serve` should run without errors or warnings
- `yarn build` should run without errors or warnings
- Code review
- Staff users
    - Should be able to navigate to Account page
    - Should be able to change first name and last name
    - Should be able to see, but not edit email
    - Should be able to change password
- Licensee users
    - Should be able to navigate to Account page
    - Should be able to see, but not edit first name, last name, email
    - Should be able to change password

Closes csg-org#194
@jsandoval81 jsandoval81 deleted the frontend/account-page branch January 29, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frontend implementation of account page

4 participants