Frontend/account page#317
Merged
isabeleliassen merged 7 commits intocsg-org:developmentfrom Nov 12, 2024
Merged
Conversation
ChiefStief
reviewed
Nov 11, 2024
Collaborator
ChiefStief
approved these changes
Nov 11, 2024
Collaborator
Author
|
@jlkravitz This is ready for your review. |
jlkravitz
reviewed
Nov 12, 2024
Collaborator
jlkravitz
left a comment
There was a problem hiding this comment.
Looks great! Two small comments.
jlkravitz
approved these changes
Nov 12, 2024
Collaborator
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen This is good to go.
isabeleliassen
approved these changes
Nov 12, 2024
landonshumway-ia
pushed a commit
to InspiringApps/JCC-CompactConnect
that referenced
this pull request
Nov 15, 2024
### Requirements List
- `yarn install --ignore-engines`
### Description List
- Add a UserAccount component
- Add a ChangePassword component
- Add an Account page component
- Add an Account link to the main nav
- Add update-staff-user call to the Data API
- Add an OAuth scope to the staff users to allow authenticated password
changes
- Update some a11y on the existing InputPassword component
- Minor updates for InputText and FormMixin components
- Updated `happy-dom` dev dependency
- https://github.com/csg-org/CompactConnect/security/dependabot/53
### Testing List
- `yarn install --ignore-engines`
- `yarn test:unit:all` should run without errors or warnings
- `yarn serve` should run without errors or warnings
- `yarn build` should run without errors or warnings
- Code review
- Staff users
- Should be able to navigate to Account page
- Should be able to change first name and last name
- Should be able to see, but not edit email
- Should be able to change password
- Licensee users
- Should be able to navigate to Account page
- Should be able to see, but not edit first name, last name, email
- Should be able to change password
Closes csg-org#194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Requirements List
yarn install --ignore-enginesDescription List
happy-domdev dependencyTesting List
yarn install --ignore-enginesyarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #194