Feat/allow renewal of privileges#326
Merged
isabeleliassen merged 10 commits intocsg-org:developmentfrom Nov 19, 2024
Merged
Conversation
To reduce config file duplication
This will allow us to track the history of license records for a licensee
69743b6 to
e6578b4
Compare
These are now managed in the common directory, so we can remove these.
54d72f8 to
5a7638c
Compare
Collaborator
Author
|
@jlkravitz This is now ready for CSG review. |
Collaborator
|
jlkravitz
previously approved these changes
Nov 18, 2024
Collaborator
There was a problem hiding this comment.
Sorry for the delay on this one- one small question but otherwise looks good! @isabeleliassen ready to merge.
isabeleliassen
approved these changes
Nov 18, 2024
jlkravitz
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to allow licensees to renew privileges if their license expiration date has been updated. We still prevent them
from purchasing the same privilege if their license has not been updated since their last purchase.
As part of this change, we have updated the data model for privilege records to include a
dateOfRenewalfield, similarto licenses. The sorting key for privilege and license records will now be suffixed with this 'dateOfRenewal' date stamp. So for example, supposing a privilege was purchased on 2024-11-08, this SK:
Will now be this tracked as this SK:
Requirements List
Description List
Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsbackend/compact-connect/tests/unit/test_api.pyCloses #295