Skip to content

Update frontend dependencies#351

Merged
isabeleliassen merged 3 commits intocsg-org:developmentfrom
InspiringApps:frontend/dependency-updates
Nov 22, 2024
Merged

Update frontend dependencies#351
isabeleliassen merged 3 commits intocsg-org:developmentfrom
InspiringApps:frontend/dependency-updates

Conversation

@jsandoval81
Copy link
Collaborator

@jsandoval81 jsandoval81 commented Nov 20, 2024

Requirements List

  • yarn install --ignore-engines

Description List

  • Updated cross-spawn
    • https://github.com/csg-org/CompactConnect/security/dependabot/56
    • cross-spawn@7.x & cross-spawn@6.x were able to be updated normally
    • cross-spawn@5.x required a new resolution + confirmation that the update to 6.x for that case was not breaking
      • In addition to smoke testing, looking at the release notes for the parent dependency execa as it moved cross-spawn from v5 to v6 as part of the execa@1.0.0 release, the code & notes for the release suggest it was just a version bump to mark the release as stable and that there were no breaking changes.

Testing List

  • yarn test:unit:all should run without errors or warnings
  • yarn serve should run without errors or warnings
  • yarn build should run without errors or warnings
  • Code review

Closes #340

@ChiefStief
Copy link
Collaborator

ChiefStief commented Nov 20, 2024

Heads up that this is also in the cloudfront-csp lambda and owasp-zap authenticator lambda. Not sure if thats a seperate ticket / instance of addressing

Edit: I guess thats just in es-lint so not the built lambdas

@jsandoval81
Copy link
Collaborator Author

@ChiefStief It looks like yesterday dependabot withdrew the original alert and issued a revised alert. The revised alert bumped down the major version requirement to v6. This made it so that the v5 dependency for @vue/cli-plugin-eslint could be resolutioned to v6 without breaking.

I've made the corresponding updates and also updated the PR and ticket notes.

@jsandoval81 jsandoval81 changed the title Update reachable cross-spawn version Update frontend dependencies Nov 21, 2024
@jsandoval81
Copy link
Collaborator Author

@jlkravitz This is ready for your review.

Copy link
Collaborator

@jlkravitz jlkravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isabeleliassen Good to merge once #352 is complete.

@isabeleliassen isabeleliassen merged commit ca1ff48 into csg-org:development Nov 22, 2024
@jsandoval81 jsandoval81 deleted the frontend/dependency-updates branch January 8, 2025 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Frontend dependency updates

4 participants