Update frontend dependencies#351
Merged
isabeleliassen merged 3 commits intocsg-org:developmentfrom Nov 22, 2024
Merged
Conversation
ChiefStief
reviewed
Nov 20, 2024
Collaborator
|
Heads up that this is also in the cloudfront-csp lambda and owasp-zap authenticator lambda. Not sure if thats a seperate ticket / instance of addressing Edit: I guess thats just in es-lint so not the built lambdas |
Collaborator
Author
|
@ChiefStief It looks like yesterday dependabot withdrew the original alert and issued a revised alert. The revised alert bumped down the major version requirement to v6. This made it so that the v5 dependency for I've made the corresponding updates and also updated the PR and ticket notes. |
ChiefStief
approved these changes
Nov 21, 2024
Collaborator
Author
|
@jlkravitz This is ready for your review. |
jlkravitz
approved these changes
Nov 22, 2024
Collaborator
jlkravitz
left a comment
There was a problem hiding this comment.
@isabeleliassen Good to merge once #352 is complete.
isabeleliassen
approved these changes
Nov 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements List
yarn install --ignore-enginesDescription List
cross-spawncross-spawn@7.x&cross-spawn@6.xwere able to be updated normallycross-spawn@5.xrequired a new resolution + confirmation that the update to6.xfor that case was not breakingexecaas it movedcross-spawnfrom v5 to v6 as part of theexeca@1.0.0release, the code & notes for the release suggest it was just a version bump to mark the release as stable and that there were no breaking changes.Testing List
yarn test:unit:allshould run without errors or warningsyarn serveshould run without errors or warningsyarn buildshould run without errors or warningsCloses #340