Convert to CloudFront origin access control#385
Merged
isabeleliassen merged 1 commit intocsg-org:developmentfrom Dec 16, 2024
Merged
Convert to CloudFront origin access control#385isabeleliassen merged 1 commit intocsg-org:developmentfrom
isabeleliassen merged 1 commit intocsg-org:developmentfrom
Conversation
landonshumway-ia
approved these changes
Dec 13, 2024
Collaborator
landonshumway-ia
left a comment
landonshumway-ia
left a comment
There was a problem hiding this comment.
Looks good, just one optional improvement
jusdino
force-pushed
the
feat/origin-access-control
branch
2 times, most recently
from
7055d0a to
6f081b1
Compare
jusdino
force-pushed
the
feat/origin-access-control
branch
from
6f081b1 to
97a19b1
Compare
Contributor
Author
|
@jlkravitz, this one is ready for you! |
jlkravitz
approved these changes
Dec 13, 2024
Collaborator
jlkravitz
left a comment
jlkravitz
left a comment
There was a problem hiding this comment.
Looks good!
@isabeleliassen Good to merge this one.
isabeleliassen
approved these changes
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description List
Testing List
bin/run_tests.shCloses #
Closes #238