feat(build): Support ImageMagick in docker build #524
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
When paired with #523, this allows processing of files using the |
Owner
|
@terussell85 It is intended too keep ImageMagick out of this main build for security reasons. However I am looking to create a separated Docker build in a separated repository, where ImageMagick is enabled as a fallback. I will let you know when such build is ready. |
Owner
|
@terussell85 ImageMagick support not available in v1.5.8 as a separated docker build https://github.com/cshum/imagor?tab=readme-ov-file#imagemagick-support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Dockerfileappears to intentionally disable support for themagickloaderwhen buildinglibvips. This makes sense from a default security sense.However, it would be nice if an
ImageMagickvariant was built for those that wanted it. This PR modifies the Dockerfile to allow passing of an ARG to enableImageMagick.Notable changes:
librawImageMagickusingimeiMost of the required ImageMagick libs for processing are already included because the previous Dockerfile installed them for libvips anyways. So those didn't have to change.
Note: This PR does not update the corresponding build workflows. It would be nice if those are updated to produce a new tag by default if these changes are accepted, but I didn't want to modify workflows that don't run on my fork.