Cast Mesh2_face_nodes attribute start_index to an integer#1
Merged
Conversation
mx-moth
changed the title
Mesh2_face_nodes to an integerMesh2_face_nodes attribute start_index to an integer
This attribute should not be a string. Support has been added to emsarray for this being a string, but it emits a warning. The example datasets should be good examples rather than broken examples.
mx-moth
force-pushed
the
austen-start-index
branch
from
946bee0 to
695b2f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attribute should not be a string. Support has been added to emsarray for this being a string, but it emits a warning. The example datasets should be good examples rather than broken examples. See csiro-coasts/emsarray/pull/26