Merged
Conversation
It was only used for UGrid in the past, and is no longer required. Nothing else seems likely to use it in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mechanism to bypass automatic format detection.
xarray accessors like
dataset.emsare read only and cached. They can not be manually set. Simply doingdataset.ems = SomeFormat(dataset)does not work, and once set a format can not be swapped out. As such, an alternate mechanism to bind formats to datasets was required. Theemsarray.state.Stateclass represents this. This has attributes that are modifiable. A new Format instance can be constructed and bound to a dataset - this will set thestate.formatattribute. Whendataset.emsis then accessed, the accessor will first check to see if a custom format has already been bound. If one has been, this will be used, else a new format will be constructed using the usual autodetection method.This allows for greater flexibility and for overriding the format if autodetection fails.