Conversation
Previously the bounds were ignored, with polygons being constructed by finding midpoints between face centres. This approach is still used as a fallback, but if a dataset defines bounds for a coordinate, those bounds are used to construct the polygons. This means CF grid topologies with 2D coordinates can have properly defined edge cells, if the bounds are defined in the dataset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the bounds were ignored, with polygons being constructed by finding midpoints between face centres. This approach is still used as a fallback, but if a dataset defines bounds for a coordinate, those bounds are used to construct the polygons.
This means CF grid topologies with 2D coordinates can have properly defined edge cells, if the bounds are defined in the dataset.