Skip to content

fix: update environment variable pattern to be less restrictive#18

Merged
jens-kuerten merged 2 commits intomainfrom
make-env-vars-less-restrictive
May 6, 2026
Merged

fix: update environment variable pattern to be less restrictive#18
jens-kuerten merged 2 commits intomainfrom
make-env-vars-less-restrictive

Conversation

@jens-kuerten
Copy link
Copy Markdown
Collaborator

@jens-kuerten jens-kuerten commented May 6, 2026

Update the environment variable pattern to allow special characters, except for "=", "," and whitespaces

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the client-side validation regex for --environment-variables in cfc environment deploy to allow a broader set of characters in environment variable values, while still preventing commas and equals signs from appearing inside values.

Changes:

  • Relaxed environment variable value validation from a restricted character class to a negated class excluding = and , (and whitespace).
  • Kept the comma-separated KEY=VALUE list format validation intact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread cfc/environment.py
Comment thread cfc/environment.py
@jens-kuerten jens-kuerten merged commit e370a66 into main May 6, 2026
4 checks passed
@jens-kuerten jens-kuerten deleted the make-env-vars-less-restrictive branch May 6, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants