fix: enable BLE DeviceFinder implementation (adds BLE to DefineConstants)#3
Closed
mephist-cne wants to merge 1 commit into
Closed
fix: enable BLE DeviceFinder implementation (adds BLE to DefineConstants)#3mephist-cne wants to merge 1 commit into
mephist-cne wants to merge 1 commit into
Conversation
…lementation - csproj DefineConstants: TCP → TCP;BLE - Plugin.BLE/Source/HAL/DeviceFinder.cs has full BLE search impl: - Initialize(IAdapter, IBluetoothLE) — call once before searching - StartDeviceSearch(scanMode, timeoutMs) — start BLE scan - StopDeviceSearch() — stop scan - OnDeviceFound event → DeviceFoundEventArgs(DeviceInformation) - OnSearchCompleted event → SearchCompletedEventArgs(timedOut) - GetDevices() / ClearDevices() / IsScanning - DeviceInformation: Id, Name, DeviceType (MODEL), Rssi, NativeDevice (IDevice) - No naming conflicts with TCP DeviceFinder partial class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed — Superseded by Issue #7
PR #3 added
BLEto<DefineConstants>to enable Plugin.BLE DeviceFinder. However, Issue #7 removes all#if TCP/#if BLEconditional compilation in favor of the return-error pattern.With Issue #7 complete, BLE and TCP HALs coexist in the same build without compile-time guards.
See: Issue #7 — Remove all #if TCP / #if BLE conditional compilation