2D Julia Operators#331
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@bewagner1 The curl operator seems wrong, and will be a point of contention for many. I suggest removing it (also it doesn't have a test) to speed up the approval. |
|
Yea I was wondering how it is mimetic operator. Doesn't seem to fit in with the rest |
|
|
||
| pa = heatmap(xc, yc, ua, title = "Approximate Solution", xlabel = "X", ylabel = "Y", colorbar_title = "u(x,y)", aspect_ratio = :equal) | ||
| display(pa) | ||
| println("Press Enter to close the plot and open the next.") |
There was a problem hiding this comment.
Hi @bewagner1 , thank you so much for your contribution!
I know we used this interactive display of figures in the existing Julia example so far, but I think it would be best to move to a system where we dynamically create an output directory for every experiment/example, use string concatenation, and save the figure (in .png file format), suing the Plots.png command.
Please see any example for instance in ClimaCore.jl
Please update this system for all examples. Thank you!
| pe = heatmap(xc, yc, ue, title = "Exact Solution", xlabel = "X", ylabel = "Y", colorbar_title = "u(x,y)", aspect_ratio = :equal) | ||
| display(pe) | ||
| println("Press Enter to close the plot and exit.") | ||
| readline() No newline at end of file |
There was a problem hiding this comment.
Does this example have an analytic solution to compare with for the error calculation?
| xlims = (0, 2), | ||
| ylims = (0, 2), | ||
| clims = (0, 2), | ||
| colorbar = true, |
There was a problem hiding this comment.
Not a huge fan of the colormap used. Can you choose a nicer palette/scheme? See examples from Plots.jl docs
There was a problem hiding this comment.
Also, does this example have an analytic solution we can use to compute the error?
|
Hi @bewagner1 , thank you so much for your contribution! Now that we have a few more examples, I would like them to be organized in a directory structure that reflects the same organization and categories we have chosen for our documentation. See the |
| m = 2*k + 1 # minimum number of cells to attain desired accuracy | ||
| dx = (east-west)/m # step length | ||
|
|
||
| path = joinpath(@__DIR__, "imgs") # Output path to store generated plots |
There was a problem hiding this comment.
Thank you! Can we please call it output? I think it's more explicit and might contain different data in different formats, not necessarily images only.
3 participants
What type of PR is this? (check all applicable)
Description
Implementation of the 2-D operators
div,grad,curl, andlapin julia as well as their periodic, mixed periodicity, and non uniform variants.Related Issues & Documents
QA Instructions, Screenshots, Recordings
Compare relevant code and examples to MATLAB implementaiton
Added/updated tests?
have not been included
Nullity tests for all operators
Read Contributing Guide and Code of Conduct
[optional] Are there any post deployment tasks we need to perform?
None that I can think of
[optional] What gif best describes this PR or how it makes you feel?