Skip to content

Sort order: Use external files for tests#112

Merged
mishanga merged 3 commits intodevfrom
tg/sort-order-tests
Dec 12, 2013
Merged

Sort order: Use external files for tests#112
mishanga merged 3 commits intodevfrom
tg/sort-order-tests

Conversation

@tonyganch
Copy link
Copy Markdown
Member

This is a small preparation for *.sass tests:

  • Divide parsing and sorting tests
  • Use external files for parsing/sorting tests
  • Add tests for correct handling of properties followed by rulesets

Structure of test files is the same as for vendor-prefix-align.
I'm lazy to type utf-8 and name of test directory every time so I added readFile() helper.

There are a lot of new files, but no scary changes.
Every line is negotiable.

May the force be with you.

tumblr_lrucb9tp131qczq24o1_500

@ghost ghost assigned mishanga Nov 18, 2013
@mishanga
Copy link
Copy Markdown
Contributor

®️ 📧 🅱️ 🅰️ 🐴 📧

Previously, if a property-value pair was followed by a linebreak and anything
but property, import or include (e.g. ruleset or condition),
the pair appeared twice in the result code.
For example,
    a {
        color: tomato;
        span {foo: bar}}
would become:
    a {
        color: tomato;
        color: tomato;
        span {foo: bar}}
That was due to incorrect removal of spaces form `deleted` array.
This commit fixes the issue.
@tonyganch
Copy link
Copy Markdown
Member Author

@mishanga, rebased 🐙

@tonyganch
Copy link
Copy Markdown
Member Author

@mishanga

pjypqaq

@mishanga
Copy link
Copy Markdown
Contributor

Only after #87 :)

@tonyganch
Copy link
Copy Markdown
Member Author

@mishanga, ping

mishanga added a commit that referenced this pull request Dec 12, 2013
Sort order: Use external files for tests
@mishanga mishanga merged commit df133d6 into dev Dec 12, 2013
@mishanga mishanga deleted the tg/sort-order-tests branch December 12, 2013 11:46
@mishanga
Copy link
Copy Markdown
Contributor

Yay!

@tonyganch
Copy link
Copy Markdown
Member Author

@mishanga, oh wow! You are my hero!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants