Skip to content

Conversation

@kizu
Copy link
Contributor

@kizu kizu commented Sep 10, 2013

No description provided.

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copypaste ;)
colon-space => combinator-space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Fixed.

@mishanga
Copy link
Contributor

I think it's really dangerous (in addition, it's useless) to use line-breaks around combinators. See the example below.
Let's change String value pattern to /[ \t]+/?

Config:

{
    "block-indent": true,
    "combinator-space": [" ", "\n"],
    "rule-indent": true
}

Origin:

@media all and (min-width:0){a+b{color:red}}

Result:

@media all and (min-width:0){
    a +
b{
        color:red
    }
}

Expected:

@media all and (min-width:0){
    a +
    b{
        color:red
    }
}

@kizu
Copy link
Contributor Author

kizu commented Sep 11, 2013

@mishanga This is the same issue as #70 — maybe we should interpret the \n in such places as “newline with the current indent”? And it would be nice to interpret \t as “the size of ident”? I guess it would be logical. Should I open a new issue on this, or we could discuss it there?

@mishanga
Copy link
Contributor

OK, I'll fix the block-indent option.

mishanga added a commit that referenced this pull request Sep 11, 2013
@mishanga mishanga merged commit d00e554 into csscomb:dev Sep 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants