Skip to content

Support sorting in *.scss and *.less files#95

Merged
mishanga merged 10 commits intodevfrom
tg/scss-less
Nov 6, 2013
Merged

Support sorting in *.scss and *.less files#95
mishanga merged 10 commits intodevfrom
tg/scss-less

Conversation

@tonyganch
Copy link
Copy Markdown
Member

This is a clone of #88, with some differences:

  • this PR is ready for merge into dev branch;
  • tests for LESS syntax were added;
  • README was updated.

a3de86262239312ce9ce969ab810a839

@tonyganch
Copy link
Copy Markdown
Member Author

@mishanga, ping

@tonyganch
Copy link
Copy Markdown
Member Author

malleable

Comment thread README.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Давай, может быть, положим gonzales-pe в какую-нибудь общую организацию? Например, ту же css.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mishanga, зачем?

@tonyganch
Copy link
Copy Markdown
Member Author

rabbit-and-cat-gif

Comment thread test/integral.expect.css Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

На этих пробелах валится npm test. По крайней мере, после ребейза.

@mishanga
Copy link
Copy Markdown
Contributor

mishanga commented Nov 6, 2013

К коду претензий нет, можно ребейзить и вливать.

– Use new method names
– Allow processing of *.scss files
– Check syntax name (css or scss)
- Use one `include` node for both `@include` and `@extend`
– Update tests
Add examples of:
- sorting properties in *.scss files
- using keywords (`$variable`, `$include` and `$import`) in sort-order config.
We should not change code while sorting.
If we want to replace delimeters, it should be done with another module,
but not sort-order.
mishanga added a commit that referenced this pull request Nov 6, 2013
Support sorting in *.scss and *.less files
@mishanga mishanga merged commit cc8d964 into dev Nov 6, 2013
@tonyganch
Copy link
Copy Markdown
Member Author

Миша, спасибо

@tonyganch tonyganch deleted the tg/scss-less branch November 7, 2013 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants